Fix: Content Classification: Make character count locale-aware#577
Fix: Content Classification: Make character count locale-aware#577hbhalodia wants to merge 3 commits into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #577 +/- ##
==========================================
Coverage 71.41% 71.41%
Complexity 1158 1158
==========================================
Files 67 67
Lines 5584 5584
==========================================
Hits 3988 3988
Misses 1596 1596
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Code looks good here but see my comment here. Thinking we may want to hold this pending that discussion as I'd love to be more consistent with how we handle this across the plugin. |
|
I am closing this PR. We can improve same in the PR - #581 |
What?
Closes #571
Why?
words, characters_excluding_spaces, or characters_including_spacesfor wordCount.How?
useContentClassificationto usewordCountTypeas suggested here and most of places, https://github.com/WordPress/gutenberg/blob/1ecc3d2fe9c819af35ef312563805bc16a103036/packages/block-library/src/post-time-to-read/edit.js#L51-L61Use of AI Tools
Testing Instructions
こんにちは。Screenshots or screencast
Changelog Entry