-
Notifications
You must be signed in to change notification settings - Fork 28
Add the Title Generation UI #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jeffpaul
merged 46 commits into
WordPress:trunk
from
dkotter:feature/title-generation-ui
Nov 26, 2025
Merged
Changes from all commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
2acd608
Get asset compiling setup with proper webpack config
dkotter cbd8a46
Add a class that can be used to load assets
dkotter c37a85b
Add the structure needed in the src directory
dkotter 443b29d
Load the assets in our feature
dkotter b7c395b
Rename file
dkotter ef41f62
Rename everywhere
dkotter 958409d
Add base structure to modify the post title block and add in a custom…
dkotter 25e7597
Add the same toolbar when not in template mode (when the title isn't …
dkotter 273c189
Update comment
dkotter 57000ef
Merge branch 'feature/title-generation-execute' into feature/title-ge…
dkotter de5fadf
Add a new wrapper around our toolbar and the title input. Add proper …
dkotter b2973b1
Keep toolbar open if sub-menu is open
dkotter 74d9adb
Remove react-dom. Ensure strings are translated
dkotter 078bf4b
Wire up the title generation API request
dkotter 394e447
Add a method to build the REST API path
dkotter 9c574d9
Add better loading state. Fix lint errors
dkotter 8ca9217
Merge branch 'feature/title-generation-execute' into feature/title-ge…
dkotter 8549253
Update doc
dkotter a6c84cb
Merge branch 'trunk' into feature/title-generation-ui
dkotter d07365f
Fix lint issues
dkotter 1d98d49
Switch from making direct API requests to the Ability endpoint to usi…
dkotter f0aba6f
Merge branch 'trunk' into feature/title-generation-ui
dkotter 4781318
Ensure the build directory ends up in our final release
dkotter 12c1f12
Merge branch 'trunk' into feature/title-generation-ui
dkotter 040c68f
Merge branch 'trunk' into feature/title-generation-ui
dkotter b770588
Remove casing options for now
dkotter c39bd1c
Allow multiple titles to be generated and show those in a modal. Allo…
dkotter 1f11540
Fix all JS lint issues. Turn our JS linting workflow on
dkotter 5703748
Merge branch 'trunk' into feature/title-generation-ui
dkotter 0390cd4
Remove autosave of title after selection
dkotter dea4acb
Rename variables to be more specific
dkotter 63c9934
Create a new component for a single title option
dkotter 88c8fa2
Add proper type
dkotter cf8cdd6
Extract the createRetry function out of the component
dkotter 36fecba
Extract the createFocusBlurHandlers function out of the component
dkotter 378116f
Extract the setupEventListeners function out of the component
dkotter ef1b112
Disconnect the observer when no longer needed
dkotter 587233c
Fix lint errors
dkotter f755562
Add new eslint config file. Change structure of prettier config file
dkotter eb8f523
Move packages to dependencies
dkotter fc4d178
Fix new lint errors
dkotter 4b89dea
Remove auto formatting in our JS lint test so we can see failures
dkotter 277c054
Remove dependencies we don't need to ensure wp-prettier is installed
dkotter c02047e
Lint fixes
dkotter fb62804
Revert back to old prettier file
dkotter 77ac717
Update minimum required WordPress version to 6.8
jeffpaul File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| { | ||
| "extends": [ "plugin:@wordpress/eslint-plugin/recommended" ], | ||
| "rules": { | ||
| // React best practices | ||
| "react/jsx-boolean-value": "error", | ||
| "react/jsx-curly-brace-presence": [ | ||
| "error", | ||
| { "props": "never", "children": "never" } | ||
| ], | ||
|
|
||
| // WordPress-specific rules, lifted from gutenberg | ||
| "@wordpress/dependency-group": "error", | ||
| "@wordpress/data-no-store-string-literals": "error", | ||
| "@wordpress/wp-global-usage": "error", | ||
| "@wordpress/react-no-unsafe-timeout": "error", | ||
| "@wordpress/i18n-hyphenated-range": "error", | ||
| "@wordpress/i18n-no-flanking-whitespace": "error", | ||
| "@wordpress/i18n-text-domain": [ | ||
| "error", | ||
| { | ||
| "allowedTextDomain": "ai" | ||
| } | ||
| ], | ||
| "@wordpress/no-unsafe-wp-apis": "off", | ||
| "import/default": "error", | ||
| "import/named": "error" | ||
| }, | ||
| "overrides": [ | ||
| { | ||
| "files": [ "**/*.ts?(x)" ], | ||
| "rules": { | ||
| "@typescript-eslint/consistent-type-imports": [ | ||
| "error", | ||
| { | ||
| "prefer": "type-imports", | ||
| "disallowTypeAnnotations": false | ||
| } | ||
| ], | ||
| "@typescript-eslint/no-shadow": "error", | ||
| "no-shadow": "off", | ||
| "jsdoc/require-param": "off", | ||
| "jsdoc/require-param-type": "off", | ||
| "jsdoc/require-returns-type": "off" | ||
| } | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Temporary for this PR? Or what?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was disabled when we initially added our default workflows as we didn't have any JS files at the time (and thus it would always fail). Now that this PR is adding JS files, turning this on