Add a screenshot and remove the functions.php file#13
Merged
Conversation
pbking
approved these changes
Nov 17, 2021
Contributor
pbking
left a comment
pbking
left a comment
There was a problem hiding this comment.
How cool is that?
Loving how super-small these child themes are able to get!
bph
added a commit
that referenced
this pull request
May 22, 2026
Bugs / correctness: - addColor: derive next index from the max existing `new-color-N` suffix instead of `value.length + 1`. Add → Remove → Add no longer produces duplicate slugs (P1). - Palette rows: assign a stable client-only `__cbtRowId` at creation time and use it as the React key, so removing a middle row no longer leaks Dropdown/ColorPicker state to subsequent rows. The ID is stripped from the payload before posting. - Update button: disable when any palette row has an empty slug; show a tooltip explaining why. Prevents the modal from POSTing an entry with `slug: ""`. Concurrent edits / lost updates (Codex P2, reviewer #12, #13): - Build a minimal patch on save: only the color-settings keys that differ from the snapshot, and the palette only if the user touched it. Stops unrelated toggles from clobbering a concurrent palette edit (RFC 7396 list-replacement) made elsewhere. - Skip the post-refresh reseed effect while the user has unsaved edits, so a mid-flight cache invalidation doesn't silently wipe in-progress work. - changeCount now reports `dirtyColorKeys.length + (paletteDirty ? 1 : 0)` — toggles count individually, palette counts as one unit. Documented in the PR description. i18n: - Update label uses `_n( 'Update (%d change)', 'Update (%d changes)', count )` so single-change pluralization is correct. - Section list in the warning notice uses `Intl.ListFormat` for locale-aware joining instead of a hard-coded English comma, with a plain `, `.join() fallback for environments without it. SCSS / observability: - Replace hard-coded `#757575`, `#ddd`, `#fff` with `$gray-700`, `$gray-300`, `$white` from `@wordpress/base-styles/_colors`. - json-editor-modal: log fetch failures via `console.error` instead of swallowing them silently. Refs #838
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a blank screenshot to the child theme and removes the functions.php file.