Fix manage fonts UI and backend when no settings are defined in theme.json#281
Merged
matiasbenedetto merged 1 commit intotrunkfrom Mar 20, 2023
Merged
Conversation
…ies is not defined by theme.json
jffng
approved these changes
Mar 20, 2023
Contributor
jffng
left a comment
jffng
left a comment
There was a problem hiding this comment.
Works as advertised, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What ?
Fix manage fonts functionality when the
settingsobject is not defined bytheme.json.If the
settings.typography.fontFamiliesis not defined in theme.json the manage fonts UI fails to render and the PHP backend throws warnings.With this PR we are fixing both the UI and the backend.
How to test
settingskey of yourtheme.json.Fixes: https://wordpress.org/support/topic/found-an-error-2/