Change jQuery event handling to use .on() method and fix Escape key handler#16
Merged
JJJ merged 1 commit intoWordPress:trunkfrom Dec 10, 2025
Merged
Change jQuery event handling to use .on() method and fix Escape key handler#16JJJ merged 1 commit intoWordPress:trunkfrom
JJJ merged 1 commit intoWordPress:trunkfrom
Conversation
1. Removes the jQuery migrate warning messages. 2. Fixes the Escape key handler to check for `event.key = "Escape"`.
JJJ
approved these changes
Dec 10, 2025
Contributor
JJJ
left a comment
JJJ
left a comment
There was a problem hiding this comment.
These changes look OK.
I think that 'click' needs a space ahead of it, but I don't consider that a blocker from merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
event.key = "Escape".