Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Replace plural categories as field name with singular category#584

Merged
obulat merged 1 commit intocategory_fixfrom
category_fix_test
Mar 24, 2022
Merged

Replace plural categories as field name with singular category#584
obulat merged 1 commit intocategory_fixfrom
category_fix_test

Conversation

@krysal
Copy link
Member

@krysal krysal commented Mar 23, 2022

Fixes

Related to #583 by @obulat

Description

Add an automated test to complement the fix and cover the bug.

Testing Instructions

Run the following commands in the main branch, note that it fails, and then try on this branch.

just up
docker-compose exec web bash
./test/run_test.sh test/audio_integration_test.py

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@krysal krysal added 💻 aspect: code Concerns the software code in the repository 🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users labels Mar 23, 2022
@krysal krysal requested a review from a team as a code owner March 23, 2022 22:02
@krysal krysal requested review from AetherUnbound and dhruvkb March 23, 2022 22:02
@krysal krysal added 🟨 priority: medium Not blocking but should be addressed soon and removed 🤖 aspect: dx Concerns developers' experience with the codebase labels Mar 23, 2022
zackkrida
zackkrida approved these changes Mar 23, 2022
View reviewed changes
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nice

api/test/media_integration.py
Comment on lines +23 to +24
# Make sure each result is from the specified category
assert all(audio_item["category"] == category for audio_item in results)
Copy link
Member

@zackkrida zackkrida Mar 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

obulat
obulat approved these changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic, @krysal ! Thank you for adding tests!

@obulat obulat merged commit c50672b into category_fix Mar 24, 2022
@obulat obulat deleted the category_fix_test branch March 24, 2022 04:48
obulat added a commit that referenced this pull request Mar 25, 2022
@obulat @AetherUnbound
Replace plural categories as field name with singular category (#583
2b50fc2 
)

* Replace plural `categories` as field name with singular `category`

Signed-off-by: Olga Bulat <obulat@gmail.com>

* Replace `categories` in the search controller

Signed-off-by: Olga Bulat <obulat@gmail.com>

* Make `categories` work, too

Signed-off-by: Olga Bulat <obulat@gmail.com>

* Add test for category filtering (#584)

* Update api/test/audio_integration_test.py

Co-authored-by: Madison Swain-Bowden <bowdenm@spu.edu>

Co-authored-by: Krystle Salazar <krystle.salazar@ciens.ucv.ve>
Co-authored-by: Madison Swain-Bowden <bowdenm@spu.edu>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AetherUnbound AetherUnbound Awaiting requested review from AetherUnbound AetherUnbound was automatically assigned from WordPress/openverse-maintainers

@dhruvkb dhruvkb Awaiting requested review from dhruvkb dhruvkb was automatically assigned from WordPress/openverse-maintainers

2 more reviewers

@zackkrida zackkrida zackkrida approved these changes

@obulat obulat obulat approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟨 priority: medium Not blocking but should be addressed soon

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@krysal @zackkrida @obulat @dhruvkb