Skip to content

Wrap contents of BODY in DIV tag in tests related to Optimization Detective#1793

Merged
westonruter merged 7 commits intotrunkfrom
add/od-root-div-to-tests
Jan 13, 2025
Merged

Wrap contents of BODY in DIV tag in tests related to Optimization Detective#1793
westonruter merged 7 commits intotrunkfrom
add/od-root-div-to-tests

Conversation

@westonruter
Copy link
Copy Markdown
Member

@westonruter westonruter commented Jan 12, 2025

Summary

This PR is part of addressing #1787. It is exclusively focused on wrapping the contents of BODY in a DIV to better align with how pages are constructed by WordPress in the real world. The subsequent PR will then replace /*[1][self::HTML]/*[2][self::BODY]/*[1][self::DIV] with /HTML/BODY/DIV.

@westonruter westonruter added [Type] Enhancement A suggestion for improvement of an existing feature [Plugin] Optimization Detective Issues for the Optimization Detective plugin [Plugin] Embed Optimizer Issues for the Embed Optimizer plugin (formerly Auto Sizes) [Plugin] Image Prioritizer Issues for the Image Prioritizer plugin (dependent on Optimization Detective) labels Jan 12, 2025
@westonruter westonruter added the skip changelog PRs that should not be mentioned in changelogs label Jan 12, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 12, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: westonruter <westonruter@git.wordpress.org>
Co-authored-by: swissspidy <swissspidy@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.43%. Comparing base (b059cbf) to head (62e498a).
Report is 10 commits behind head on trunk.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk    #1793   +/-   ##
=======================================
  Coverage   57.43%   57.43%           
=======================================
  Files          84       84           
  Lines        6508     6508           
=======================================
  Hits         3738     3738           
  Misses       2770     2770           
Flag Coverage Δ
multisite 57.43% <ø> (ø)
single 34.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from update/od-snapshot-testing to trunk January 13, 2025 14:34
@westonruter westonruter merged commit 2df83d0 into trunk Jan 13, 2025
@westonruter westonruter deleted the add/od-root-div-to-tests branch January 13, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Plugin] Embed Optimizer Issues for the Embed Optimizer plugin (formerly Auto Sizes) [Plugin] Image Prioritizer Issues for the Image Prioritizer plugin (dependent on Optimization Detective) [Plugin] Optimization Detective Issues for the Optimization Detective plugin skip changelog PRs that should not be mentioned in changelogs [Type] Enhancement A suggestion for improvement of an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants