Skip to content

Enhance experience when installing and activating a standalone plugin#900

Merged
swissspidy merged 13 commits intofeature/creating-standalone-pluginsfrom
fix/880
Dec 18, 2023
Merged

Enhance experience when installing and activating a standalone plugin#900
swissspidy merged 13 commits intofeature/creating-standalone-pluginsfrom
fix/880

Conversation

@mukeshpanchal27
Copy link
Member

Summary

Fixes #880

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@mukeshpanchal27 mukeshpanchal27 added [Type] Enhancement A suggestion for improvement of an existing feature Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release Creating standalone plugins labels Dec 12, 2023
@mukeshpanchal27 mukeshpanchal27 self-assigned this Dec 12, 2023
@mukeshpanchal27 mukeshpanchal27 marked this pull request as ready for review December 12, 2023 09:53
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mukeshpanchal27, it's great you found a solution for this problem. I left a bit of feedback below, but the overall approach looks solid.

mukeshpanchal27 and others added 2 commits December 14, 2023 10:02
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
@mukeshpanchal27
Copy link
Member Author

Thank you, @felixarntz, @swissspidy, and @westonruter, for your feedback. I have addressed it, and the PR is now ready for review.

mukeshpanchal27 and others added 4 commits December 15, 2023 10:24
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Co-authored-by: Weston Ruter <westonruter@google.com>
@mukeshpanchal27
Copy link
Member Author

@felixarntz @westonruter, I identified an edge case while installing multiple plugins and try to activate first plugin where we encountered an incorrect selector in event.target.activeElement. Consequently, In b936064 i have updated the selector in the logic, and the issue has been resolved. Could you please review it? Thank you.

Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @mukeshpanchal27!

Only one minor thing that would be good to address, but not a blocker.

mukeshpanchal27 and others added 3 commits December 18, 2023 11:23
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Co-authored-by: Weston Ruter <westonruter@google.com>
@mukeshpanchal27
Copy link
Member Author

@swissspidy Could you kindly take a moment to review the recent changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release [Type] Enhancement A suggestion for improvement of an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants