Enhance experience when installing and activating a standalone plugin#900
Enhance experience when installing and activating a standalone plugin#900swissspidy merged 13 commits intofeature/creating-standalone-pluginsfrom
Conversation
felixarntz
left a comment
There was a problem hiding this comment.
Thanks @mukeshpanchal27, it's great you found a solution for this problem. I left a bit of feedback below, but the overall approach looks solid.
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
|
Thank you, @felixarntz, @swissspidy, and @westonruter, for your feedback. I have addressed it, and the PR is now ready for review. |
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com> Co-authored-by: Weston Ruter <westonruter@google.com>
|
@felixarntz @westonruter, I identified an edge case while installing multiple plugins and try to activate first plugin where we encountered an incorrect selector in |
felixarntz
left a comment
There was a problem hiding this comment.
Great work @mukeshpanchal27!
Only one minor thing that would be good to address, but not a blocker.
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Co-authored-by: Weston Ruter <westonruter@google.com>
|
@swissspidy Could you kindly take a moment to review the recent changes? |
Summary
Fixes #880
admin/perflab-admin.jsfile.update.jsupdates plugin activation link in 1 sec so in our custom script we will update it after 1.5 sec.Checklist
[Focus]orInfrastructurelabel.[Type]label.no milestonelabel.