Skip to content

Conversation

@felixarntz
Copy link
Member

Fixes #128

@felixarntz felixarntz added this to the 0.3.0 milestone Nov 26, 2025
@felixarntz felixarntz added the [Type] Enhancement A suggestion for improvement. label Nov 26, 2025
@felixarntz felixarntz marked this pull request as ready for review November 26, 2025 23:27
@github-actions
Copy link

github-actions bot commented Nov 26, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: felixarntz <flixos90@git.wordpress.org>
Co-authored-by: JasonTheAdams <jason_the_adams@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@JasonTheAdams JasonTheAdams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@felixarntz Looks good! Just one suggestion: Now that this method is public, let's add unit tests for it.

@felixarntz
Copy link
Member Author

@JasonTheAdams Tests added!

I've also refreshed this with latest trunk, and bumped the @since n.e.x.t annotations to say @since 0.3.0. So we should be able to ship shortly after this is merged, pending some smoke testing using cli.php.

Copy link
Member

@JasonTheAdams JasonTheAdams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🚀

@JasonTheAdams JasonTheAdams merged commit 70e5e22 into trunk Nov 27, 2025
6 checks passed
@JasonTheAdams JasonTheAdams deleted the enhancement/is-supported-public branch November 27, 2025 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Enhancement A suggestion for improvement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make PromptBuilder::isSupported public

3 participants