GitHub Actions workflow updates#235
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @felixarntz. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #235 +/- ##
=========================================
Coverage 88.12% 88.12%
Complexity 1213 1213
=========================================
Files 60 60
Lines 3934 3934
=========================================
Hits 3467 3467
Misses 467 467
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Updates GitHub Actions workflows to follow least-privilege permissions and add per-job timeouts to prevent runaway executions.
Changes:
- Disable default workflow token permissions (
permissions: {}) and move required permissions to the job level. - Add
timeout-minutes: 20to PHP lint/test jobs and the props-bot job. - Clarify permission intent with inline comments in workflow YAML.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/props-bot.yml | Refines job-level permissions and keeps a job timeout for the props-bot workflow. |
| .github/workflows/php-test.yml | Disables default permissions, adds a job timeout, and grants contents: read for checkout. |
| .github/workflows/php-lint.yml | Disables default permissions, adds a job timeout, and grants contents: read for checkout. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Gah, forgot the props.
This setting has been adjusted. |
This updates the GitHub Actions workflow files to:
Once this PR is merged, the Settings -> Actions -> Workflow permissions setting can be changed by a repo admin to "Read repository contents and packages permissions".
References
Use of AI
Claude Code was used to create the initial changes. All permissions and timeouts changes were reviewed and adjusted by me where necessary.