-
Notifications
You must be signed in to change notification settings - Fork 13
[BlockMarkupURLProcessor] Support URLs in CSS #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
59 commits
Select commit
Hold shift + click to select a range
d332205
Kickoff migrating URLs in CSS
adamziel adb07a9
Support Unicode escapes
adamziel 40380e5
Simplify the replacements, format the code
adamziel f6710aa
Improve clarity of the CSSUrlProcessor
adamziel ff59ffd
Test CSS unicode escapes decoder
adamziel 0813667
Ditch regexp
adamziel 3b69730
PHPCS
adamziel 95a1302
Do not allocate memory for every match optimistically
adamziel e98c3ba
Test for data URI
adamziel 3bdbda6
Skip data URIs in the replacement logic
adamziel 8a5e734
Optimize get_parsed_url() for data uris
adamziel 3739a95
Simplify the CSS URL Processor
adamziel 0d5d95f
Move URL parsing from CSS processor to BlockMarkupURLProcessor
adamziel 5feafb5
Use wp.org as a test domain
adamziel c387bd5
Simplify the css processor integration
adamziel 2b2170b
Add a generic CSS Processor
adamziel ee3ed64
Simplify consume_string()
adamziel cd32ab2
Pass most CSS tokenizer test cases
adamziel 4b75739
Less failures
adamziel d3d1b07
1 last failure
adamziel 0245453
Remove the offending fuzzer test
adamziel 8996fd4
Adjust details
adamziel 38f89af
Use codepoints instead of bytes for decoding idents
adamziel 2382057
Use the bundled unicode decoder
adamziel 663db21
Do not concat to repr when consuming numeric values
adamziel c647699
Comments, renaming for clarity
adamziel 8227327
Simplify consume_ident_sequence()
adamziel 2182023
Fix inconsistencies in CSSProcessor
adamziel 20947cb
Simplify is_valid_escape
adamziel 43301e6
Simplify would_next_3_code_points_start_an_ident
adamziel 2c0b357
Simplify is_ident_code_point_at
adamziel 46ce619
Reformat and further simplify
adamziel eeba23f
Reformat and further simplify
adamziel b427f9d
PHPCS
adamziel b7fcbef
Merge branch 'trunk' into migrate-urls-in-css
adamziel e288522
use css processor in css url processor
adamziel 2340e19
Merge branch 'trunk' into migrate-urls-in-css
adamziel 09a6d6d
Simplify the css url processor
adamziel e0c5010
Fix last failing test
adamziel 5583d5e
Test data URI parsing and memory treatment
adamziel 562475c
Preliminary test suite cleanup with a more thorough rewrite coming
adamziel c32a771
More readable escaping test cases
adamziel 25019d8
More readable escaping test cases
adamziel 0c4d80e
Additional tests for set() and one larger CSS snippet
adamziel 65e6ff6
Delete components/DataLiberation/Tests/css-test-cases.php
adamziel c5c0f4a
Delete generate-css-tests.mjs
adamziel 3817238
Rollback obsolete changes
adamziel 616bffc
Remove unneeded WP polyfills, rename class to CSSURLProcessor
adamziel ed95beb
Remove unrelated chante
adamziel 5135a2a
brush up the test_comprehensive_url_replacement_in_complex_css case
adamziel f89769c
format
adamziel cb4b4ed
format
adamziel a1afc11
Fix URL replacement in BlockMarkupUrlProcessorTest
adamziel 123f36d
Remove extra llm changes
adamziel 0716d74
Merge branch 'trunk' into migrate-urls-in-css
adamziel 015ea44
Enhance memory usage tests in CSSUrlProcessorTest
adamziel 7a64cdf
Fix unit tests
adamziel ff7d636
Move CSSProcessor to its own namespace
adamziel 052ad8a
Add comments
adamziel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.