CSSProcessor::set_token_value( $new_value ) #198
Merged
+1,763
−1,353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
commented
Oct 30, 2025
adamziel
added a commit
that referenced
this pull request
Oct 31, 2025
Follows up on #197 by adding a `set_token_value( $new_value )` method to allow rewriting CSS. At the moment, it only supports updating the URL token value. ```php $css = 'background: url(old.jpg);'; $processor = CSSProcessor::create( $css ); while ( $processor->next_token() ) { if ( CSSProcessor::TOKEN_URL === $processor->get_token_type() ) { // URL with safe characters: letters, digits, hyphens, underscores, dots, slashes. $processor->set_token_value( "image😀.jpg ("special")" ); } } echo $processor->get_updated_css(); // background: url("image😀.jpg (\22 special\22 )"); ``` ## Implementation details `set_token_value( $new_value )` always uses the quoted URL syntax to encode the new URL. It only escapes quotes newline characters, backslashes, and double quotes. All other bytes are preserved as-is. PR #198 was supposed to merge this into trunk, but I never updated the base. cc @dmsnell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up on #197 by adding a
set_token_value( $new_value )method to allow rewriting CSS. At the moment, it only supports updating the URL token value.Implementation details
set_token_value( $new_value )always uses the quoted URL syntax to encode the new URL. It only escapes quotes newline characters, backslashes, and double quotes. All other bytes are preserved as-is.cc @dmsnell