Update fixtures for valid blueprints as per blueprints v2 spec #214
+26
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my wpcom work, I found the following valid blueprint fixtures were out of date as per blueprints v2 spec. Our validator flagged them, and it now passes with the changes in this PR.
Also, note that these fixtures files are currently not used in the repo. Nor they were in the original commit. Seems like an intermediary artifact. With this PR, we can atleast have them to be upto dated & can possibly start using them in tests that we can add. In #213 I have the entire incorrect valid fixture file in the test, but if they are indeed to kept around, it can also use the fixture file.