Fix GitRemote HEAD fetch#294
Merged
Merged
Conversation
265daad to
59527a5
Compare
59527a5 to
85efbf6
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Fixes
GitRemote::pull( 'HEAD' )/fetch( 'HEAD' )soHEADis resolved as the remote symbolic ref instead of being rewritten torefs/heads/HEAD.Closes #292.
Rationale
Blueprints can use
git:directorywithref: "HEAD". The PHP runtime treated that as a branch namedHEAD, then failed because remotes advertiseHEAD, notrefs/heads/HEAD.Implementation
HEADwhen the caller passes exactlyHEAD.pull( 'HEAD' )result to localHEAD, soGitFilesystemreads the fetched commit.ls-refsattributes separately from ref names, includingpeeled:hashes.HEADfrom an in-memory Git endpoint and parsing NUL-separated ref attributes.Testing instructions
Also manually checked
ls_refs( 'HEAD' )and shallowpull( 'HEAD' )againsthttps://github.com/woocommerce/wc-smooth-generator.git.