remove verbose mode for rsync

[pfefferle]

I had problems with travis and the verbose mode of rsync:

The job exceeded the maximum log length, and has been terminated.

I would suggest to remove the flag, or at least to hide it behind an env var.

[getsource]

I like the idea of having an environment variable to toggle it. Maybe something referencing verbose, or perhaps enabling "debug"?

[pfefferle]

How should I call the var?

• $WPT_VERBOSE
• $WPT_VERBOSE_LOGGING
• $WPT_VERBOSE_OUTPUT
• ...

any suggestions?

[pfefferle]

I made some changes... It is easier, to discuss about code ;)

[getsource]

Thanks much! What do you think about WPT_DEBUG?

I'll leave a couple comments in the PR as well on specifics.

[getsource]

Yes, it's working for me. I may be missing something, so apologies if so!
I think this is a bit more consistent with the way the rest of the string variables are handled in code so far.

If it doesn't exist at all (not in .env at all), it will end up false (bool).
if it is defined in .env as empty, it ends up as an empty string,

In both cases it's "set" and "empty".

[getsource]

I'm seeing the 👍 but didn't want to assume incorrectly -- if you'd like to merge, go ahead -- if not, either I can, or of course we can keep discussing.

It looks good to me -- thank you!

[pfefferle]

I like your change and I am fine with merging it 😊

[pfefferle]

I am the MR owner, so I cannot approve the changes.

[getsource]

Looks good to me -- thank you!