Refine DirectDB sniff error messages#1218
Merged
davidperezgar merged 1 commit intotrunkfrom Mar 15, 2026
Merged
Conversation
c8312dd to
1fbed40
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
davidperezgar
approved these changes
Mar 15, 2026
frantorres
approved these changes
Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1217
Summary
Shortens and simplifies
PluginCheck.Security.DirectDB(DirectDBSniff) output so messages are easier to scan in CI/IDE.Changes
Unescaped parameter %s used in $wpdb->%s(%s)%stoUnescaped parameter %s used in $wpdb->%s()%s. The SQL string is no longer included.$foo assigned unsafely at line 14.). Assignment code snippets are no longer included inunwind_unsafe_assignments().Testing
Example code
The sniff reports the unescaped
$fooon thequery()line. The “before” message included the full first argument and full assignment context; the “after” message does not.Before
If the assignment had used e.g.
sanitize_text_field(), a second line of context was added:After (exact message from phpcs)
Only the first line of context is shown, and the assignment code snippet is omitted. The “Note: …” line is no longer shown (it was always part of the extra context block).