Skip to content

fix: address WordPress.org plugin review feedback#62

Merged
josephfusco merged 3 commits into
mainfrom
fix/wporg-review-feedback
Jul 2, 2026
Merged

fix: address WordPress.org plugin review feedback#62
josephfusco merged 3 commits into
mainfrom
fix/wporg-review-feedback

Conversation

@josephfusco

@josephfusco josephfusco commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Addresses WordPress.org pre-review feedback for presence-api.

  • readme.txt: fix Contributors slug (flavorjoefusco), sync changelog with CHANGELOG.md, add Text Domain header.
  • includes/post-list.php: enqueue the Editors column CSS via wp_add_inline_style (gated on edit.php) instead of an inline <style> tag.
  • presence-api.php: remove redundant load_plugin_textdomain(); guard the WP_DEBUG-only debug-tool requires with file_exists() and their hooks with function_exists().
  • .distignore: exclude db-viewer.php and debugger-widget.php from the release build.

Naming (wp_/WP_ prefixes, wp-presence/v1, plugin name/slug) is unchanged and handled in a separate reply to the review team.

Verified: PHPCS + PHPStan clean; simulated dist build ships no debug tools and no inline <script>/<style>.


AI disclosure: this PR was prepared with AI assistance (Claude Code).

- readme.txt: correct Contributors slug (flavor -> joefusco), sync
  changelog with CHANGELOG.md, add Text Domain header.
- Enqueue post list Editors column styles via wp_add_inline_style
  instead of an inline <style> tag (gated on edit.php).
- Remove redundant load_plugin_textdomain(); WP 7.0 auto-loads
  directory translations.
- Exclude WP_DEBUG-only db-viewer.php and debugger-widget.php from the
  release build (.distignore) and guard their require/hook sites so a
  debug install without them does not fatal.

Intentional core-proposal naming (wp_/WP_ prefixes, wp-presence/v1,
"Presence API") is retained and defended in the reviewer reply.
@github-actions

github-actions Bot commented Jun 29, 2026

Copy link
Copy Markdown

▶ Preview in WordPress Playground

Open in WordPress Playground

Boots a fresh WordPress with this PR's presence-api build, seeds 5 demo users, and drops you on the dashboard.

Stress-test variant: 40 demo users · Built from 0801410bcdee472f141eb4e48609d2d26a94c84d. Auto-updates when you push.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses WordPress.org plugin pre-review feedback by aligning the plugin’s packaging/docs with directory expectations and by replacing direct inline CSS output with WordPress enqueue APIs, while ensuring dev-only tooling won’t break distributed builds.

Changes:

  • Updates readme.txt metadata (Contributors, Text Domain) and expands the changelog section.
  • Switches post-list “Editors” column styling to wp_add_inline_style() on admin_enqueue_scripts (scoped to edit.php).
  • Makes WP_DEBUG developer tooling includes resilient to missing files and updates release packaging exclusions in .distignore.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
readme.txt Updates plugin readme headers and changelog content for WP.org submission.
presence-api.php Guards dev-tool includes and updates hook registration for debug widget functions.
includes/post-list.php Moves Editors column CSS from raw <style> output to enqueued inline styles on edit.php.
.distignore Excludes debug tooling PHP files from distributed builds.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread presence-api.php Outdated
Comment thread readme.txt
Comment on lines +27 to +33
= 0.1.2 =
* Enqueue post list "Editors" column styles instead of inlining them.
* Exclude WP_DEBUG-only developer tooling from the release build.
* Remove redundant load_plugin_textdomain() call.
* Add WordPress Playground blueprint for one-click testing.
* Replace deprecated get_page_by_title() with WP_Query.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@josephfusco josephfusco marked this pull request as ready for review July 2, 2026 16:50
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @Copilot.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props joefusco.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@josephfusco josephfusco merged commit 032a3d0 into main Jul 2, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants