Update initialization of the acfL10n object to ensure it's available globally
#118
Conversation
cbravobernal
force-pushed
the
fix/ensure-acfL10n-available-globally
branch
from
7801775 to
68ce307
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR updates the initialization of the global acfL10n object in order to ensure it exists in all browsers and scopes. This change replaces the old undefined check with a more concise default assignment.
- Updated global initialization of acfL10n
- Improved inline documentation to clarify behavior
Comments suppressed due to low confidence (1)
assets/src/js/_acf.js:677
- The new initialization logic replaces any falsy value for window.acfL10n with an object. Confirm that this behavior is intended, as it will override non-undefined falsy values (e.g., null, false, or empty string).
window.acfL10n = window.acfL10n || {};
| if ( window.acfL10n == undefined ) { | ||
| acfL10n = {}; | ||
| } | ||
| // Make sure a global acfL10n object exists to prevent errors in other scopes |
There was a problem hiding this comment.
Outside the scope of this PR, but we should probably add some checks on coding style outside PHP files, e.g. to create a consistent way for commenting etc (https://github.com/WordPress/secure-custom-fields/pull/118/files#diff-2c39fc5eb9675f3ca4efecbc4a219c3c560c52ad26d42d45217ad878755a59dfL852 - note the ending stop symbol)
There was a problem hiding this comment.
That's a good catch, thanks for noticing 💯
There was a problem hiding this comment.
It's not the only inconsistency, don't worry!
3 participants
What and why
When working with translations in the client, I ran into some issues with the
acfL10nnot being initialized properly in my scope. This change ensuresacfL10nis available in all browsers and conditions.Testing instructions
Just use SCF and notice that nothing changed for the current features. However, this change will come in handy in the new features we are working on inside the editor.