Skip to content

Conversation

@priethor
Copy link
Contributor

@priethor priethor commented Dec 2, 2025

What

Fixes e2e tests that are broken in trunk after #259

Why

The refactor introduced in #259 was incompatible with WP 6.8, but I didn't catch the test regression as the PR was running the tests against trunk, not 6.8.

How

Only trying to open the metabox panel if the button to open it exists, which will support both cases where the metaboxes panel is open and collapsed.

@github-actions
Copy link

github-actions bot commented Dec 2, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props priethor.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 9.37%. Comparing base (d7a87b1) to head (d141230).
⚠️ Report is 1 commits behind head on trunk.

Additional details and impacted files
@@           Coverage Diff           @@
##             trunk    #267   +/-   ##
=======================================
  Coverage     9.37%   9.37%           
  Complexity    4288    4288           
=======================================
  Files          266     266           
  Lines        33159   33159           
=======================================
  Hits          3108    3108           
  Misses       30051   30051           
Flag Coverage Δ
e2e 21.83% <ø> (ø)
phpunit 6.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@priethor
Copy link
Contributor Author

priethor commented Dec 2, 2025

Confirming the fix works with WP latest (6.8 as of now), which was failing in trunk. Reverting the e2e testing matrix.

@priethor priethor merged commit 49fe41f into trunk Dec 2, 2025
8 checks passed
@priethor priethor deleted the fix/broken-e2e-tests branch December 2, 2025 19:02
@cbravobernal cbravobernal added this to the 6.7.0 milestone Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants