Skip to content

Conversation

@priethor
Copy link
Contributor

@priethor priethor commented Dec 3, 2025

What

Fixes the e2e suite so that it also works with WordPress 6.2

Why

SCF requires a minimum WordPress version of 6.2, but the wp test utils we are using don't support older versions

How

  • Creating an extended editor object that provides compatible ways to get:
    • The preview page (the button text changed in WP 6.3)
    • The canvas (there was no iframe in 6.2)
  • Switching term/user tests from ID selectors to text locators

@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 10.98%. Comparing base (6d201a1) to head (a31f266).
⚠️ Report is 2 commits behind head on trunk.

Additional details and impacted files
@@             Coverage Diff             @@
##             trunk     #271      +/-   ##
===========================================
+ Coverage     9.37%   10.98%   +1.61%     
  Complexity    4288     4288              
===========================================
  Files          266      266              
  Lines        33159    33159              
===========================================
+ Hits          3108     3642     +534     
+ Misses       30051    29517     -534     
Flag Coverage Δ
e2e 29.55% <ø> (+7.72%) ⬆️
phpunit 6.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@priethor priethor force-pushed the fix/e2e-tests-in-wp62 branch from b4d6b33 to 75ca7dc Compare December 5, 2025 05:48
@priethor
Copy link
Contributor Author

priethor commented Dec 5, 2025

Confirming tests pass in CI against WP 6.2, reverting to use latest.

@priethor priethor marked this pull request as ready for review December 5, 2025 06:53
@github-actions
Copy link

github-actions bot commented Dec 5, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props priethor.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@priethor priethor merged commit e3f9e67 into trunk Dec 5, 2025
8 checks passed
@priethor priethor deleted the fix/e2e-tests-in-wp62 branch December 5, 2025 07:05
@cbravobernal cbravobernal added this to the 6.7.1 milestone Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants