Skip to content

Fix checkbox toggle functionality#283

Merged
priethor merged 4 commits intoWordPress:trunkfrom
jamieburchell:fix/toggle-all-checkbox
Dec 16, 2025
Merged

Fix checkbox toggle functionality#283
priethor merged 4 commits intoWordPress:trunkfrom
jamieburchell:fix/toggle-all-checkbox

Conversation

@jamieburchell
Copy link
Contributor

@jamieburchell jamieburchell commented Dec 12, 2025

Fixes #282

Also standardises the use of var and $ instead of const and jQuery respectively and generally simplifies the logic.

@github-actions
Copy link

github-actions bot commented Dec 12, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props jamieburchell, priethor.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@priethor priethor added the [Type] Bug Something isn't working label Dec 16, 2025
@priethor priethor added this to the 6.8.0 milestone Dec 16, 2025
Copy link
Contributor

@priethor priethor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, @jamieburchell !

I can reproduce the issue in trunk and can confirm that this patch elegantly solves it.

I've added a couple of unit tests to prevent future regressions; they fail in trunk but pass in this PR, as expected.

@priethor priethor merged commit 3d03744 into WordPress:trunk Dec 16, 2025
8 checks passed
@jamieburchell jamieburchell deleted the fix/toggle-all-checkbox branch December 16, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Toggle All does not work and emits console error on tools page

2 participants