Implement column metadata for SHOW, EXPLAIN/DESCRIBE, ANALYZE, CHECK, OPTIMIZE, REPAIR
#271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanJakes
force-pushed
the
column-meta-statements
branch
4 times, most recently
from
e066e8b to
01a0126
Compare
adamziel
reviewed
Oct 22, 2025
| $this->last_column_meta[] = $stmt->getColumnMeta( $i ); | ||
| } | ||
|
|
||
| $this->store_last_column_meta( $stmt ); |
Collaborator
There was a problem hiding this comment.
Maybe store_last_column_meta_from_resultset() to distinguish that from regular assignments that don't involve $stmt?
Member
Author
There was a problem hiding this comment.
@adamziel I renamed it to store_last_column_meta_from_statement since I'm passing it a PDOStatement. Hope that makes sense.
adamziel
approved these changes
Oct 22, 2025
JanJakes
force-pushed
the
fully-qualified-table-names
branch
from
827bb7a to
c7a06a6
Compare
JanJakes
force-pushed
the
column-meta-statements
branch
from
01a0126 to
32462e5
Compare
Member
Author
|
@adamziel I also rebased this to resolve conflicts. |
Collaborator
|
Cool! Looks good |
… OPTIMIZE, REPAIR
Using "root" as the user name makes sense considering that with the SQLite driver, the user gets all available permissions.
JanJakes
force-pushed
the
column-meta-statements
branch
from
32462e5 to
91bc3e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement column metadata for the following statements:
SHOW COLLATION,SHOW DATABASES,SHOW CREATE TABLE,SHOW TABLE STATUS,SHOW TABLES,SHOW FULL TABLES,SHOW COLUMNS,SHOW INDEX,SHOW GRANTS,SHOW VARIABLESEXPLAIN,DESCRIBEANALYZE,CHECK,OPTIMIZE,REPAIR