Make native parser extension visible#407
Merged
Merged
Conversation
be04923 to
b3ee23f
Compare
5b68210 to
797ba0c
Compare
797ba0c to
849df13
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Reorganizes the root README so Quick start stays first and the optional Native MySQL Parser Extension is discoverable without taking over the landing flow. The README links to the GitHub Pages landing page with the published WASM release list, manifest links, “Run in Playground” buttons, and native extension details.
Also expands
packages/php-ext-wp-mysql-parser/README.mdwith local build/load instructions, WASM artifact details, checksum verification steps, and benchmark commands. The benchmark scripts now run cleanly on PHP 8.4+, can emit JSON, report exact processed counts, and the parser benchmark goes through the integration loader sophp -d extension=...measures the native parser path instead of accidentally staying on the pure-PHP classes.Why
The native extension and WASM artifacts were hard to discover. This keeps the normal README quick start prominent while giving users a clear path to optional native-extension docs, Playground links, and reproducible benchmark commands.
Self-review fixes
run-parser-benchmark.phpto include the first query and to load throughsrc/load.php, matching runtime native-vs-PHP class selection.Related Pages work
Validation
composer validate --no-check-allphp -l packages/mysql-on-sqlite/tests/tools/run-lexer-benchmark.phpphp -l packages/mysql-on-sqlite/tests/tools/run-parser-benchmark.phpphp -l packages/mysql-on-sqlite/tests/tools/run-native-extension-benchmark.phpphp packages/mysql-on-sqlite/tests/tools/run-lexer-benchmark.php --json --limit=100php packages/mysql-on-sqlite/tests/tools/run-parser-benchmark.php --json --limit=100php packages/mysql-on-sqlite/tests/tools/run-native-extension-benchmark.php --json --limit=100php -d extension=/path/to/libwp_mysql_parser.dylib packages/mysql-on-sqlite/tests/tools/run-native-extension-benchmark.php --json --limit=100php -d extension=/path/to/libwp_mysql_parser.dylib packages/mysql-on-sqlite/tests/tools/run-parser-benchmark.php --json --limit=100npx @wp-playground/cli@latest run-blueprint --php=8.4 --php-extension=https://wordpress.github.io/sqlite-database-integration/wp_mysql_parser-wasm-extension/latest/manifest.json --blueprint=https://wordpress.github.io/sqlite-database-integration/native-extension/blueprint.json --verbosity=quietNote:
composer run check-cscould not run in this workspace becausevendor/bin/phpcsis not installed locally; CI runs it with dependencies installed.