Use PHP 8.5 for native parser demo#418
Merged
Merged
Conversation
…arser-php85-demo # Conflicts: # index.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Updates the GitHub Pages native parser demo to use PHP 8.5 instead of the temporary PHP 8.3 pin:
php=8.5.Why?
The PHP 8.3 pin was a workaround for missing Zend exports in the Playground browser runtime. Once WordPress/wordpress-playground#3690 and rebuilt web PHP.wasm artifacts ship, the browser runtime should support the published
wp_mysql_parserside modules across PHP 8.0-8.5.Dependency
Do not merge/publish this until the Playground web-runtime fix and rebuilt artifacts are live, and #417 passes against them.