fix: constructors must not return value

[sjinks]

What?

This pull request removes a redundant return $this; statement from the constructor. This aligns with PHP class construction practices.

Why?

In PHP, constructors are void and, therefore, must not return a value.

How?

Remove return $this;.

Testing Instructions

N/A - there are no functional changes.

Screenshots or screencast

N/A

Changelog Entry

Fixed - removed return statement from Two_Factor_Provider's constructor.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: sjinks <volodymyrkolesnykov@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[georgestephanis]

Looks good. This was due to legacy behavior and how we were storing the instances in the static previously I believe, but didn't update with the newer version?

Either way, LGTM