Add _doing_it_wrong() notices for missing script, style, and script module dependencies

[deepakpra]

This PR adds developer-facing _doing_it_wrong() notices when a script or script module is enqueued with dependencies that have not been registered.

Currently, WordPress silently skips printing such assets, which makes dependency issues difficult to diagnose. This change improves debugging clarity during development.

What’s changed
✅ Classic scripts (WP_Scripts)

• Detects missing dependencies in all_deps().
• Emits a _doing_it_wrong() notice identifying the script handle and missing dependency handles.

✅ Script modules (WP_Script_Modules)

• Detects missing dependencies during dependency sorting.
• Emits a _doing_it_wrong() notice with the module ID and missing dependency IDs.

Both implementations:

• Prevent duplicate notices using a static cache.

Trac ticket: https://core.trac.wordpress.org/ticket/64229

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props deepakprajapati, westonruter.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions]

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

• The Plugin and Theme Directories cannot be accessed within Playground.
• All changes will be lost when closing a tab with a Playground instance.
• All changes will be lost when refreshing the page.
• A fresh instance is created each time the link below is clicked.
• Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
  it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

[westonruter]

Let's make sure to add unit tests for these changes as well.

[westonruter]

This is looking good to me. I will plan to finish reviewing and commit by next week.

[westonruter]

I'm testing this with the following plugin code:

add_action(
	'wp_enqueue_scripts',
	static function () {
		wp_enqueue_script( 'bad-script', '/bad.js', array( 'nope' ) );
		wp_enqueue_style( 'bad-style', '/bad.css', array( 'nope' ) );
		wp_enqueue_script_module( 'bad-module', '/bad.mjs', array( 'nope' ) );
	}
);

I get the following log entries:

• PHP Notice: Function WP_Dependencies::all_deps was called incorrectly. The style with the handle bad-style was enqueued with dependencies that are not registered: nope. Please see Debugging in WordPress for more information. (This message was added in version 7.0.0.) in /var/www/src/wp-includes/functions.php on line 6131
• PHP Notice: Function WP_Dependencies::all_deps was called incorrectly. The script with the handle bad-script was enqueued with dependencies that are not registered: nope. Please see Debugging in WordPress for more information. (This message was added in version 7.0.0.) in /var/www/src/wp-includes/functions.php on line 6131
• PHP Notice: Function WP_Script_Modules::sort_item_dependencies was called incorrectly. The script module bad-module was enqueued with dependencies that are not registered: nope. Please see Debugging in WordPress for more information. (This message was added in version 7.0.0.) in /var/www/src/wp-includes/functions.php on line 6131
• PHP Notice: Function WP_Script_Modules::sort_item_dependencies was called incorrectly. The script module bad-module was enqueued with dependencies that are not registered: nope. Please see Debugging in WordPress for more information. (This message was added in version 7.0.0.) in /var/www/src/wp-includes/functions.php on line 6131
• PHP Notice: Function WP_Script_Modules::sort_item_dependencies was called incorrectly. The script module bad-module was enqueued with dependencies that are not registered: nope. Please see Debugging in WordPress for more information. (This message was added in version 7.0.0.) in /var/www/src/wp-includes/functions.php on line 6131
• PHP Notice: Function WP_Dependencies::all_deps was called incorrectly. The style with the handle bad-style was enqueued with dependencies that are not registered: nope. Please see Debugging in WordPress for more information. (This message was added in version 7.0.0.) in /var/www/src/wp-includes/functions.php on line 6131
• PHP Notice: Function WP_Dependencies::all_deps was called incorrectly. The script with the handle bad-script was enqueued with dependencies that are not registered: nope. Please see Debugging in WordPress for more information. (This message was added in version 7.0.0.) in /var/www/src/wp-includes/functions.php on line 6131

The duplication of the notices is indeed not great. I think what I'll do is just add a private member variable to the classes to keep track of what has been flagged with _doing_it_wrong(). This will solve the problem of a static variable not being reset with tests.

What's also confusing is the functions being flagged are unrelated to the functions which may have been called incorrectly by the user. So I think I'll update these to use the WP_Scripts::add(), WP_Styles::add(), and WP_Script_Modules::register() methods which are actually flagged as being called incorrectly. This will make much more sense to a developer.

Also, I'll add quotes around the initial handle ID.

[westonruter]

There, I think it is more developer-friendly now. When registering a script, style, and script module with missing dependencies, I now get just three notices:

1. Notice: Function WP_Styles::add was called incorrectly. The style with the handle "bad-style" was enqueued with dependencies that are not registered: nope. Please see Debugging in WordPress for more information. (This message was added in version 7.0.0.) in /var/www/src/wp-includes/functions.php on line 6131
   
2. Notice: Function WP_Scripts::add was called incorrectly. The script with the handle "bad-script" was enqueued with dependencies that are not registered: nope. Please see Debugging in WordPress for more information. (This message was added in version 7.0.0.) in /var/www/src/wp-includes/functions.php on line 6131
   
3. Notice: Function WP_Script_Modules::register was called incorrectly. The script module "bad-module" was enqueued with dependencies that are not registered: nope. Please see Debugging in WordPress for more information. (This message was added in version 7.0.0.) in /var/www/src/wp-includes/functions.php on line 6131
   

[westonruter]

This method shouldn't have emitted an incorrect notice to begin with. I see it was due to a typo in this line:

wordpress-develop/tests/phpunit/tests/script-modules/wpScriptModules.php

Line 2062 in 3f93553

$deregister( array( 'b', 'c ' ) );

Note the extra space after c.

This was introduced in r60999. I've fixed this in a553244.

[westonruter]

Notices as displayed in Query Monitor:

This is in addition to Query Monitor's built-in warnings for scripts and styles (but it doesn't currently warn for missing script module dependencies):

[github-actions]

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 61323
GitHub commit: 3901a29

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.