Only output sourceURL if SCRIPT_DEBUG enabled.#10984
Only output sourceURL if SCRIPT_DEBUG enabled.#10984peterwilsoncc wants to merge 1 commit intoWordPress:trunkfrom
SCRIPT_DEBUG enabled.#10984Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @markkap. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
this sounds less than optimal as it seems to lead to the next workflow
I would go for something less conditional like show it only to admins (I am assuming all developers have or can safely be given admin role, not sure how much this assumption is true in real life) |
|
on a second thought maybe it does not worth the effort at all as it adds relatively so little to the generated HTML, but if this kind of filtering must be done, maybe its better to use the enviroment setting as a signal. |
| function twentyfifteen_javascript_detection() { | ||
| $js = "(function(html){html.className = html.className.replace(/\bno-js\b/,'js')})(document.documentElement);"; | ||
| $js .= "\n//# sourceURL=" . rawurlencode( __FUNCTION__ ); | ||
| $js .= SCRIPT_DEBUG ? "\n//# sourceURL=" . rawurlencode( __FUNCTION__ ) : ''; |
There was a problem hiding this comment.
Instead of referencing SCRIPT_DEBUG repeatedly, what if there was instead a helper function like wp_should_print_inline_source_url()? This function could apply a filter which would have a default value set to SCRIPT_DEBUG. In this way, a site could opt-in to having sourceURL but not have to also serve unminified scripts and styles.
There was a problem hiding this comment.
@westonruter How's this for a signature:
wp_should_print_inline_source_url( string $source, bool $echo = false ) : string
If not printing/returning the source URL the return value can be an empty string.
Random notes/thoughts:
- Bundled themes will require the function be polyfilled.
- Should there be a
wp_scripts_andwp_stylesfunction to allow devs to target specific asset types? - What is the internal escaping logic, or should that be the responsibility of the calling function?
There was a problem hiding this comment.
What about wp_should_print_inline_source_url(): bool? I think it could be a drop-in replacement for SCRIPT_DEBUG as you have in your PR here. Themes could continue to use SCRIPT_DEBUG if the function doesn't exist.
|
I think this can be closed based on further discussion in the ticket. There are no clear problems with the |
Modifies the sourceURL output so it's only done if the
SCRIPT_DEBUGconstant is set to true.Trac ticket: https://core.trac.wordpress.org/ticket/64369
Testing notes
define( 'SCRIPT_DEBUG', false );to your wp-config filedefine( 'SCRIPT_DEBUG', true );Use of AI Tools
Copilot helped with auto-complete/type ahead.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.