Skip to content

AI: Remove dead polyfills.php from php-ai-client#11113

Closed
gziolo wants to merge 3 commits intoWordPress:trunkfrom
gziolo:update/remove-php-ai-client-polyfills
Closed

AI: Remove dead polyfills.php from php-ai-client#11113
gziolo wants to merge 3 commits intoWordPress:trunkfrom
gziolo:update/remove-php-ai-client-polyfills

Conversation

@gziolo
Copy link
Member

@gziolo gziolo commented Mar 2, 2026

Trac ticket: https://core.trac.wordpress.org/ticket/64591

Summary

  • Removes src/wp-includes/php-ai-client/src/polyfills.php which is dead code — the generated autoloader only handles class autoloading, so this function-only file is never loaded
  • The four polyfilled functions (array_is_list, str_starts_with, str_contains, str_ends_with) are already provided by WordPress Core in wp-includes/compat.php
  • Updates tools/php-ai-client/installer.sh to strip the file during future library updates

Follow-up to #10881 (comment).

🤖 Generated with Claude Code

Trac ticket: https://core.trac.wordpress.org/ticket/64591

The file is never loaded because the generated autoloader only handles
class autoloading, and the four polyfilled functions (`array_is_list`,
`str_starts_with`, `str_contains`, `str_ends_with`) are already provided
by WordPress Core in `wp-includes/compat.php`.

Also updates `installer.sh` to strip the file during future library updates.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions
Copy link

github-actions bot commented Mar 2, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props gziolo, flixos90.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@gziolo gziolo requested a review from felixarntz March 2, 2026 14:09
@github-actions
Copy link

github-actions bot commented Mar 2, 2026

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@gziolo gziolo self-assigned this Mar 2, 2026
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gziolo Thank you, LGTM!

rm -rf "$TARGET_DIR/third-party/$path"
done

# Remove polyfills.php — WordPress Core already provides these functions in compat.php.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Remove polyfills.php — WordPress Core already provides these functions in compat.php.
# Remove polyfills.php — WordPress Core already provides these functions in compat.php, and the file is never loaded by the custom autoloader.

@felixarntz
Copy link
Member

@felixarntz felixarntz closed this Mar 3, 2026
@gziolo gziolo deleted the update/remove-php-ai-client-polyfills branch March 3, 2026 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants