Skip to content

I18N: Add missing translator comments and fix string issues for 7.0 #11152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sanketio wants to merge 2 commits into from
Closed

I18N: Add missing translator comments and fix string issues for 7.0 #11152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e9ff01
I18N: Add missing translator comments and fix misplaced comment
sanketio Mar 4, 2026
42dff11
Merge branch 'trunk' into fix/64244
sanketio Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/wp-includes/class-wp-phpmailer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,15 +38,19 @@ public function __construct( $exceptions = false ) {
*/
public static function setLanguage( $langcode = 'en', $lang_path = '' ) {
static::$language = array(
/* translators: SMTP authentication error message. */
Copy link
Copy Markdown
Member

@mukeshpanchal27 mukeshpanchal27 Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For string what is benefit of having translators comment here? Better to use that when use placeholders (e.g., %s, %d).

'authenticate' => __( 'SMTP Error: Could not authenticate.' ),
'buggy_php' => sprintf(
/* translators: 1: mail.add_x_header. 2: php.ini */
__( 'Your version of PHP is affected by a bug that may result in corrupted messages. To fix it, switch to sending using SMTP, disable the %1$s option in your %2$s, or switch to MacOS or Linux, or upgrade your PHP version.' ),
'mail.add_x_header',
'php.ini'
),
/* translators: SMTP connection error message. */
'connect_host' => __( 'SMTP Error: Could not connect to SMTP host.' ),
/* translators: SMTP data transmission error message. */
'data_not_accepted' => __( 'SMTP Error: Data not accepted.' ),
/* translators: Email message body is empty. */
'empty_message' => __( 'Message body empty' ),
/* translators: There is a space after the colon. */
'encoding' => __( 'Unknown encoding: ' ),
Expand Down Expand Up @@ -79,14 +83,17 @@ public static function setLanguage( $langcode = 'en', $lang_path = '' ) {
'smtp_code' => __( 'SMTP code: ' ),
/* translators: There is a space after the colon. */
'smtp_code_ex' => __( 'Additional SMTP info: ' ),
/* translators: connect() is a PHP function name and should not be translated. */
'smtp_connect_failed' => __( 'SMTP connect() failed.' ),
/* translators: There is a space after the colon. */
'smtp_detail' => __( 'Detail: ' ),
/* translators: There is a space after the colon. */
'smtp_error' => __( 'SMTP server error: ' ),
/* translators: There is a space after the colon. */
'variable_set' => __( 'Cannot set or reset variable: ' ),
/* translators: SMTPUTF8 is a protocol extension name and should not be translated. */
'no_smtputf8' => __( 'Server does not support SMTPUTF8 needed to send to Unicode addresses' ),
/* translators: PHP IMAP is a PHP extension name. RFC822 is an email standard name. Both should not be translated. */
'imap_recommended' => __( 'Using simplified address parser is not recommended. Install the PHP IMAP extension for full RFC822 parsing.' ),
/* translators: %s: $useimap */
'deprecated_argument' => sprintf( __( 'Argument %s is deprecated' ), '$useimap' ),
Expand Down
2 changes: 1 addition & 1 deletion src/wp-includes/pluggable.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1937,11 +1937,11 @@ function wp_notify_postauthor( $comment_id, $deprecated = null ) {
break;
}

/* translators: %s: Comment URL. */
if ( 'note' === $comment->comment_type ) {
$notify_message .= get_edit_post_link( $comment->comment_post_ID, 'url' ) . "\r\n";
} else {
$notify_message .= get_permalink( $comment->comment_post_ID ) . "#comments\r\n\r\n";
/* translators: %s: Comment URL. */
$notify_message .= sprintf( __( 'Permalink: %s' ), get_comment_link( $comment ) ) . "\r\n";
}

Expand Down
Loading