Skip to content

Admin reskin: Remove line-height from input elements #11383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
t-hamano wants to merge 5 commits into from
Closed

Admin reskin: Remove line-height from input elements #11383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7e8a286
Admin reskin: Remove line-height from input elements
t-hamano Mar 28, 2026
14ce6d7
Fix more places
t-hamano Mar 28, 2026
24c630f
Don't remove line-height for select elements
t-hamano Mar 28, 2026
ea7f3d0
Remove line-height from the color picker
t-hamano Mar 28, 2026
935dd5e
Increase height for date and time format input
t-hamano Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/wp-admin/css/color-picker.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,6 @@
width: 4rem;
font-size: 12px;
font-family: monospace;
line-height: 2.33333333; /* 28px */
margin: 0;
padding: 0 5px;
vertical-align: top;
Expand Down
1 change: 0 additions & 1 deletion src/wp-admin/css/common.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1115,7 +1115,6 @@ th.action-links {

.wp-filter .search-form input[type="search"] {
min-height: 32px;
line-height: 2.14285714; /* 30px for 32px height with 14px font */
Copy link
Copy Markdown
Contributor Author

@t-hamano t-hamano Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plugins > Add Plugin > "Search Plugins" field

Image

padding: 0 8px;
}

Expand Down
1 change: 0 additions & 1 deletion src/wp-admin/css/customize-controls.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2184,7 +2184,6 @@ p.customize-section-description {
}

.themes-filter-bar .wp-filter-search {
line-height: 2.14285714; /* 30px for 32px compact input */
Copy link
Copy Markdown
Contributor Author

@t-hamano t-hamano Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Activate classic theme > Appearance > Customize > Click "Change" button > "Search Plugins" field

Image

padding: 0 10px 0 30px;
max-width: 100%;
width: 40%;
Expand Down
1 change: 0 additions & 1 deletion src/wp-admin/css/dashboard.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,7 +533,6 @@
width: 40%;
margin: 0;
min-height: 32px;
line-height: 2.14285714;
Copy link
Copy Markdown
Contributor Author

@t-hamano t-hamano Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dashboard > WordPress Events and News > Click "Select location"

Image

padding: 0 8px;
}

Expand Down
6 changes: 1 addition & 5 deletions src/wp-admin/css/forms.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ input[type="url"],
input[type="week"] {
padding: 0 12px;
/* inherits font size 14px */
line-height: 2.71428571; /* 38px for 40px min-height */
Copy link
Copy Markdown
Contributor Author

@t-hamano t-hamano Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the basic style for the input element.

min-height: 40px;
}

Expand Down Expand Up @@ -816,7 +815,6 @@ p.search-box {
p.search-box input[type="search"],
p.search-box input[type="text"] {
min-height: 32px;
line-height: 2.14285714; /* 30px for 32px height with 14px font */
Copy link
Copy Markdown
Contributor Author

@t-hamano t-hamano Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Search posts

Image

padding: 0 8px;
}

Expand Down Expand Up @@ -1237,8 +1235,7 @@ table.form-table td .updated p {
.options-general-php input.small-text {
width: 56px;
margin: -2px 0;
min-height: 24px;
line-height: 1.71428571; /* 24px for 14px font size */
min-height: 32px;
}

.options-general-php .spinner {
Expand Down Expand Up @@ -1601,7 +1598,6 @@ table.form-table td .updated p {
-webkit-appearance: none;
padding: 0 12px;
min-height: 40px;
line-height: 2.5; /* 40px for 16px font */
Copy link
Copy Markdown
Contributor Author

@t-hamano t-hamano Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the basic style for mobile viewports.

}

::-webkit-datetime-edit {
Expand Down
2 changes: 0 additions & 2 deletions src/wp-admin/css/list-tables.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -686,7 +686,6 @@ th.sorted a span {
font-size: 13px;
text-align: center;
min-height: 32px;
line-height: 2.30769231; /* 30px for 32px height with 13px font */
Copy link
Copy Markdown
Contributor Author

@t-hamano t-hamano Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pagination input field

Image

padding: 0 8px;
}

Expand Down Expand Up @@ -1099,7 +1098,6 @@ tr.inline-edit-row td {

.inline-edit-row select,
.inline-edit-row input:where(:not([type=checkbox],[type=radio],[type=submit],[type=button])) {
line-height: 2.14285714;
Copy link
Copy Markdown
Contributor Author

@t-hamano t-hamano Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick edit form

Image

min-height: 32px;
padding: 0 8px 0 8px;
}
Expand Down
1 change: 0 additions & 1 deletion src/wp-admin/css/media.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,7 +568,6 @@ border color while dragging a file over the uploader drop area */

.media-frame.mode-grid .media-toolbar input[type="search"] {
min-height: 32px;
line-height: 2.14285714; /* 30px for 32px height with 14px font */
Copy link
Copy Markdown
Contributor Author

@t-hamano t-hamano Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Media > Switch to Grid View > Search media field

Image

padding: 0 8px;
}

Expand Down
Loading