Skip to content

I18N: Use _x() with verb context for translatable 'Reply' strings #11406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sanketio wants to merge 1 commit into
base: trunk
Choose a base branch
from
+11 −6
Open

I18N: Use _x() with verb context for translatable 'Reply' strings #11406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/js/_enqueues/admin/edit-comments.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ var getCount, updateCount, updateCountText, updatePending, updateApproved,
updateHtmlTitle, updateDashboardText, updateInModerationText, adminTitle = document.title,
isDashboard = $('#dashboard_right_now').length,
titleDiv, titleRegEx,
__ = wp.i18n.__;
__ = wp.i18n.__, _x = wp.i18n._x;

/**
* Extracts a number from the content of a jQuery element.
Expand Down Expand Up @@ -370,7 +370,8 @@ window.setCommentsList = function() {

} else {
if ( settings.data.id == replyID )
replyButton.text( __( 'Reply' ) );
/* translators: Comment reply button text. */
replyButton.text( _x( 'Reply', 'verb' ) );

c.find( '.row-actions span.view' ).removeClass( 'hidden' ).end()
.find( 'div.comment_status' ).html( '1' );
Expand Down Expand Up @@ -1012,7 +1013,8 @@ window.commentReply = {
if ( c.hasClass('unapproved') ) {
replyButton.text( __( 'Approve and Reply' ) );
} else {
replyButton.text( __( 'Reply' ) );
/* translators: Comment reply button text. */
replyButton.text( _x( 'Reply', 'verb' ) );
}

$('#replyrow').fadeIn(300, function(){ $(this).show(); });
Expand Down
3 changes: 2 additions & 1 deletion src/wp-admin/includes/class-wp-comments-list-table.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -875,7 +875,8 @@ protected function handle_row_actions( $item, $column_name, $primary ) {
'replyto',
'vim-r comment-inline',
esc_attr__( 'Reply to this comment' ),
__( 'Reply' )
/* translators: Comment reply button text. */
_x( 'Reply', 'verb' )
);
}

Expand Down
3 changes: 2 additions & 1 deletion src/wp-admin/includes/dashboard.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -772,7 +772,8 @@ function _wp_dashboard_recent_comments_row( &$comment, $show_date = true ) {
$comment->comment_ID,
$comment->comment_post_ID,
esc_attr__( 'Reply to this comment' ),
__( 'Reply' )
/* translators: Comment reply button text. */
_x( 'Reply', 'verb' )
);

$actions['spam'] = sprintf(
Expand Down
3 changes: 2 additions & 1 deletion src/wp-includes/comment-template.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1756,7 +1756,8 @@ function get_comment_reply_link( $args = array(), $comment = null, $post = null
$defaults = array(
'add_below' => 'comment',
'respond_id' => 'respond',
'reply_text' => __( 'Reply' ),
/* translators: Comment reply button text. */
'reply_text' => _x( 'Reply', 'verb' ),
/* translators: Comment reply button text. %s: Comment author name. */
'reply_to_text' => __( 'Reply to %s' ),
'login_text' => __( 'Log in to Reply' ),
Expand Down
Loading