REST API: Build oEmbed proxy URL with wp.apiRequest (#41554)#11479
REST API: Build oEmbed proxy URL with wp.apiRequest (#41554)#11479pranav-inamdar wants to merge 1 commit intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @pi-20. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Summary
Replaces localized
oEmbedProxyUrl(full REST URL from PHP) withwp.apiRequest()usingnamespace: 'oembed/1.0'andendpoint: 'proxy', so admin embed code builds the oEmbed proxy URL consistently with other REST clients and avoids passingrest_url()output through script localization.Follow-up to #40919; implements #41554.
Changes
wp.apiRequest()for oEmbed proxy previews.wp_localize_script/ settings property from PHP (where previously passed intowp.media/ related scripts).Testing
Manual:
/oembed/1.0/proxyREST route (or equivalent with plain permalinks /rest_route).Automated:
tests/phpunit/tests/oembed/controller.php) in your environment.Trac ticket: https://core.trac.wordpress.org/ticket/41554
Use of AI Tools
AI assistance: Yes
Tool(s): Cursor
Used for: Exploring the codebase, drafting and iterating on the patch, and PR description text; implementation was reviewed and adjusted manually before submission.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.