_pad_term_counts() uses string-concatenated SQL without prepared statement#11542
_pad_term_counts() uses string-concatenated SQL without prepared statement#11542rajeshcpr wants to merge 3 commits intoWordPress:trunkfrom
Conversation
…ement $object_types values are not individually escaped via $wpdb->prepare(). They use esc_sql() only at the get_taxonomy() call, but imploded directly into the query string. The array keys are integer IDs but are not cast. This should use prepare() with placeholders.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
…ement $object_types values are not individually escaped via $wpdb->prepare(). They use esc_sql() only at the get_taxonomy() call, but imploded directly into the query string. The array keys are integer IDs but are not cast. This should use prepare() with placeholders.
_pad_term_counts() uses string-concatenated SQL without prepared statement
$object_types values are not individually escaped via $wpdb->prepare(). They use esc_sql() only at the
get_taxonomy() call, but imploded directly into the query string. The array keys are integer IDs but are not cast.
This should use prepare() with placeholders.
Trac ticket: https://core.trac.wordpress.org/ticket/65055
Fixes #65055
Use of AI Tools
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.