Skip to content

_pad_term_counts() uses string-concatenated SQL without prepared statement#11542

Open
rajeshcpr wants to merge 3 commits intoWordPress:trunkfrom
rajeshcpr:rajeshcpr-patch-7
Open

_pad_term_counts() uses string-concatenated SQL without prepared statement#11542
rajeshcpr wants to merge 3 commits intoWordPress:trunkfrom
rajeshcpr:rajeshcpr-patch-7

Conversation

@rajeshcpr
Copy link
Copy Markdown

_pad_term_counts() uses string-concatenated SQL without prepared statement

$object_types values are not individually escaped via $wpdb->prepare(). They use esc_sql() only at the
get_taxonomy() call, but imploded directly into the query string. The array keys are integer IDs but are not cast.
This should use prepare() with placeholders.

Trac ticket: https://core.trac.wordpress.org/ticket/65055
Fixes #65055

Use of AI Tools


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

…ement

$object_types values are not individually escaped via $wpdb->prepare(). They use esc_sql() only at the
  get_taxonomy() call, but imploded directly into the query string. The array keys are integer IDs but are not cast.
  This should use prepare() with placeholders.
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props rajeshcp.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@rajeshcpr rajeshcpr marked this pull request as draft April 9, 2026 19:35
@rajeshcpr rajeshcpr closed this Apr 9, 2026
@rajeshcpr rajeshcpr deleted the rajeshcpr-patch-7 branch April 9, 2026 19:35
@rajeshcpr rajeshcpr restored the rajeshcpr-patch-7 branch April 9, 2026 19:41
@rajeshcpr rajeshcpr reopened this Apr 9, 2026
@rajeshcpr rajeshcpr marked this pull request as ready for review April 9, 2026 19:46
@rajeshcpr rajeshcpr marked this pull request as draft April 9, 2026 19:46
…ement

$object_types values are not individually escaped via $wpdb->prepare(). They use esc_sql() only at the
  get_taxonomy() call, but imploded directly into the query string. The array keys are integer IDs but are not cast.
  This should use prepare() with placeholders.
@rajeshcpr rajeshcpr marked this pull request as ready for review April 9, 2026 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant