Skip to content

Update error message for disallowed username characters#11590

Open
marcarmengou wants to merge 1 commit intoWordPress:trunkfrom
marcarmengou:username-disallowed-message
Open

Update error message for disallowed username characters#11590
marcarmengou wants to merge 1 commit intoWordPress:trunkfrom
marcarmengou:username-disallowed-message

Conversation

@marcarmengou
Copy link
Copy Markdown

@marcarmengou marcarmengou commented Apr 16, 2026

This PR replaces illegal characters with disallowed characters, removing unnecessarily alarmist language for the user.

https://core.trac.wordpress.org/ticket/65084

@github-actions
Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props marc4.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@marcarmengou marcarmengou changed the title Update error message for invalid username characters Update error message for disallowed username characters Apr 16, 2026
@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copy link
Copy Markdown

@nikunj8866 nikunj8866 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @marcarmengou, thanks for the contribution!

As per the CONTRIBUTING.md of this repository, pull requests must include a link to a corresponding ticket on core.trac.wordpress.org:

Pull requests are accepted as long as there is a corresponding Trac ticket. Please include a link to a pre-existing ticket on https://core.trac.wordpress.org/ with every pull request.

Could you please:

  1. Open a new ticket at https://core.trac.wordpress.org/ describing the rationale for changing illegal charactersdisallowed characters (worth noting this also affects existing translations)
  2. Update this PR description with the Trac ticket URL
  3. Add the has-patch keyword on the Trac ticket and link back to this PR

For reference: GitHub Pull Requests for Code Review – Make WordPress Core

Happy to help if you have questions about the process!

@marcarmengou marcarmengou requested a review from nikunj8866 April 17, 2026 08:03
Copy link
Copy Markdown

@nikunj8866 nikunj8866 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants