Skip to content

Add transparent pseudo-element on active buttons for border in Windows High Contrast mode #11680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sabernhardt wants to merge 1 commit into
base: trunk
Choose a base branch
from
+14 −0
Open

Add transparent pseudo-element on active buttons for border in Windows High Contrast mode #11680

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/wp-includes/css/buttons.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,7 @@ TABLE OF CONTENTS:
color: var(--wp-admin-theme-color-darker-20, #183ad6);
border-color: var(--wp-admin-theme-color, #3858e9);
box-shadow: inset 0 2px 6px -2px var(--wp-admin-theme-color-darker-20);
position: relative;
}

.wp-core-ui .button.active:focus {
Expand All @@ -203,6 +204,19 @@ TABLE OF CONTENTS:
box-shadow: inset 0 2px 6px -2px var(--wp-admin-theme-color-darker-20), 0 0 0 var(--wp-admin-border-width-focus, 1.5px) var(--wp-admin-theme-color, #3858e9);
}

/* Only visible in Windows High Contrast mode */
.wp-core-ui .button.active:before {
content: "";
display: block;
position: absolute;
width: 100%;
height: 100%;
border: 1px solid transparent;
border-bottom-width: 3px;
left: 0;
Comment on lines +213 to +216
Copy link
Copy Markdown
Author

@sabernhardt sabernhardt May 16, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this only adds a border on one side, it probably would be better to position the pseudo-element at the bottom with zero height.

Suggested change
height: 100%;
border: 1px solid transparent;
border-bottom-width: 3px;
left: 0;
height: 0;
border-top: 3px solid transparent;
bottom: 0;
left: 0;

With focus outline:

alignment options with focus on the selected button, None month, day and post name permalink tags are selected, with focus on post name

Copy link
Copy Markdown
Contributor

@t-hamano t-hamano May 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loos good 👍

box-sizing: border-box;
}

.wp-core-ui .button[disabled],
.wp-core-ui .button:disabled,
.wp-core-ui .button.disabled,
Expand Down
Loading