Skip to content

Fix rest_is_integer validation logic #11883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
coderGtm wants to merge 4 commits into
base: trunk
Choose a base branch
from
+22 −1
Open

Fix rest_is_integer validation logic #11883

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fafc4d4
fix: rest_is_integer validation logic
coderGtm May 20, 2026
b3f5da3
phpcs: improve formatting
coderGtm May 20, 2026
8ba541f
feat: add scientific notation in validation scope
coderGtm May 21, 2026
4ac1ff7
fix: handle boolean values correctly
coderGtm May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion src/wp-includes/rest-api.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1570,7 +1570,28 @@ function rest_is_boolean( $maybe_bool ) {
* @return bool True if an integer, otherwise false.
*/
function rest_is_integer( $maybe_integer ) {
return is_numeric( $maybe_integer ) && round( (float) $maybe_integer ) === (float) $maybe_integer;
if ( is_int( $maybe_integer ) ) {
return true;
}

if ( is_bool( $maybe_integer ) || ! is_scalar( $maybe_integer ) ) {
return false;
}

$integer_pattern = '/^[+-]?\d+$/';
$scientific_pattern = '/^[+-]?\d+e\+?\d+$/i';

$value = trim( (string) $maybe_integer );
Copy link
Copy Markdown
Member

@westonruter westonruter May 21, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrectly resulting in rest_is_integer( true ) returning true, since (string) true === '1'.

It should return false: https://playground.wordpress.net/php-playground.html#eyJjb2RlIjoiPD9waHBcbnJlcXVpcmUgJy93b3JkcHJlc3Mvd3AtbG9hZC5waHAnO1xuXG52YXJfZHVtcCggcmVzdF9pc19pbnRlZ2VyKCB0cnVlICkgKTsiLCJwaHAiOiI4LjQiLCJ3cCI6IjcuMCJ9

Copy link
Copy Markdown
Author

@coderGtm coderGtm May 21, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I fixed it.


if ( preg_match( $integer_pattern, $value ) ) {
return true;
}

if ( preg_match( $scientific_pattern, $value ) ) {
return true;
}

return false;
}

/**
Expand Down
Loading