Editor: adjust grid layout for filters#11885
Conversation
Refactor the grid layout for media attachment filters to improve alignment and responsiveness. This change ensures that the labels and select elements are properly positioned within the media frame.
|
Hi @KhushalSainS! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @KhushalSainS. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
Hi @yogeshbhutkar, Thank you for pointing this out. I’ve updated the patch to address the alignment issue shown in the screenshot. The fix is scoped specifically to media frames where the type filter is hidden and only the date filter is displayed, so the default toolbar layout with both filters remains unaffected.
|


What?
Fixes the alignment of the "Filter by date" dropdown in the Media Library modal when the "Filter by type" dropdown is hidden.
Why?
When a media frame is opened with the library restricted to a single MIME type, for example:
the "Filter by type" dropdown is hidden as expected. However, the date filter was still assigned to the second column of the toolbar grid in
src/wp-includes/css/media-views.css:As a result, the date filter appeared offset to the right, leaving an empty space where the type filter would normally appear.
How?
Updates the media toolbar grid positioning so the date filter uses the first column by default.
When the type filter is present, sibling selectors move the date filter back to the second column. This preserves the existing two-filter layout while fixing single-MIME-type media frames where the type filter is hidden.
Screenshots
Testing Instructions
Go to
/wp-admin/post-new.php.Open the browser DevTools console.
Run:
Switch to the Media Library tab.
Confirm that the "Filter by date" dropdown is aligned flush-left when the type filter is hidden.
Open a normal media frame where both filters are visible.
Confirm that "Filter by type" and "Filter by date" still appear side by side.
Trac ticket: https://core.trac.wordpress.org/ticket/65276
Use of AI Tools
AI assistance: Yes
Tool(s): Codex, ChatGPT
Model(s): GPT-5.5
Used for: Testing guidance, CSS fix suggestion. Final changes were reviewed and edited by me.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.