Skip to content

Media Library: Fix filter toolbar loading spinner alignment#11888

Open
yogeshbhutkar wants to merge 1 commit into
WordPress:trunkfrom
yogeshbhutkar:fix(media-library)/loading-spinner-misaligned
Open

Media Library: Fix filter toolbar loading spinner alignment#11888
yogeshbhutkar wants to merge 1 commit into
WordPress:trunkfrom
yogeshbhutkar:fix(media-library)/loading-spinner-misaligned

Conversation

@yogeshbhutkar
Copy link
Copy Markdown

@yogeshbhutkar yogeshbhutkar commented May 20, 2026

Trac ticket: https://core.trac.wordpress.org/ticket/65275

What?

Fixes the Media Library loading spinner alignment in the secondary filter toolbar.

Why?

With the toolbar using a grid layout for filter controls, the spinner could fall out of place depending on which filters were rendered. That also caused an unintended scrollbar in the filter area because the spinner no longer appeared adjacent to the filters.

How?

Keeps the existing grid layout intact and positions the spinner relative to .media-toolbar-secondary, so it stays aligned at the end of the toolbar and loads adjacent to the filters.

Screenshots

Before After
image-01-before image-01-after
image-02-before image-2-after

Use of AI Tools

AI assistance: Yes
Tool(s): Codex
Model(s): GPT-5.4
Used for: Initial code skeleton; final implementation was reviewed and edited by me.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 20, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props yogeshbhutkar, dhruvang21.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@dhruvang21
Copy link
Copy Markdown

@yogeshbhutkar Tested using the WP playground seems to work fine in desktop view but we need to fix it in responsive views

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants