Build/Test Tools: Update stale step comment lists in reusable workflow files#12054
Open
itzmekhokan wants to merge 1 commit into
Open
Build/Test Tools: Update stale step comment lists in reusable workflow files#12054itzmekhokan wants to merge 1 commit into
itzmekhokan wants to merge 1 commit into
Conversation
…w files. The step comment lists in two reusable workflow files were out of sync with their actual steps. In `reusable-phpstan-static-analysis-v1.yml`, the comment list was not updated when the workflow was refactored to add `Set up Node.js`, `Install npm dependencies`, and `Build WordPress` steps. Three steps were missing and the order of `Logs debug information` and `Installs Composer dependencies` was incorrect. In `reusable-coding-standards-php.yml`, the `Get last Monday's date` step was present in the job but absent from the step comment list.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The step comment lists (the
# - Step description.comment blocks at the top of workflow jobs) in two reusable workflow files were out of sync with their actual steps.In
reusable-phpstan-static-analysis-v1.yml, the comment list was not updated when the workflow was refactored to remove theGet last Monday's datestep and addSet up Node.js,Install npm dependencies, andBuild WordPresssteps. Three steps were missing from the comment list and the order of two others was incorrect.In
reusable-coding-standards-php.yml, theGet last Monday's datestep is present in the job but was absent from the step comment list.Trac ticket: https://core.trac.wordpress.org/ticket/65391
Use of AI Tools
N/A
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.