Code Modernization: Use str_contains() instead of strpos()#12085
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
str_contains()was introduced in PHP 8.0 to perform a case-sensitive check indicating if the string to search in (haystack) contains the given substring (needle).WordPress core includes a polyfill for
str_contains()on PHP < 8.0 as of WordPress 5.9.This PR replaces
false !== strpos( ... )andfalse === strpos( ... )withstr_contains()in core files, making the code more readable and consistent, as well as better aligned with modern development practices.Introduced in r60269 and r60939
Trac ticket: https://core.trac.wordpress.org/ticket/65408
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.