Admin Bar: Add custom property for responsive height value#1234
Closed
ryelle wants to merge 3 commits intoWordPress:masterfrom
Closed
Admin Bar: Add custom property for responsive height value#1234ryelle wants to merge 3 commits intoWordPress:masterfrom
ryelle wants to merge 3 commits intoWordPress:masterfrom
Conversation
desrosj
added a commit
to desrosj/wordpress-develop
that referenced
this pull request
Jan 10, 2022
Fixes WordPress#1234, #947583, #84757.
desrosj
added a commit
to desrosj/wordpress-develop
that referenced
this pull request
Jan 10, 2022
Fixes WordPress#1234, #947583, #84757.
desrosj
added a commit
to desrosj/wordpress-develop
that referenced
this pull request
Jan 10, 2022
desrosj
added a commit
to desrosj/wordpress-develop
that referenced
this pull request
Jan 10, 2022
desrosj
added a commit
to desrosj/wordpress-develop
that referenced
this pull request
Jan 10, 2022
desrosj
added a commit
to desrosj/wordpress-develop
that referenced
this pull request
Jan 10, 2022
desrosj
added a commit
to desrosj/wordpress-develop
that referenced
this pull request
Jan 11, 2022
Fixes WordPress#1234, #947583, #84757.
desrosj
added a commit
to desrosj/wordpress-develop
that referenced
this pull request
Jan 11, 2022
Fixes WordPress#1234, #947583, #84757.
desrosj
added a commit
to desrosj/wordpress-develop
that referenced
this pull request
Jan 11, 2022
Fixes WordPress#1234, #947583, #84757.
desrosj
added a commit
to desrosj/wordpress-develop
that referenced
this pull request
Jan 11, 2022
Fixes WordPress#1234, #947583, #84757.
desrosj
added a commit
to desrosj/wordpress-develop
that referenced
this pull request
Jan 11, 2022
Fixes WordPress#1234, #947583, #84757.
desrosj
added a commit
to desrosj/wordpress-develop
that referenced
this pull request
Jan 11, 2022
Fixes WordPress#1234, #947583, #84757.
desrosj
added a commit
to desrosj/wordpress-develop
that referenced
this pull request
Jan 11, 2022
Fixes WordPress#1234, #947583, #84757.
desrosj
added a commit
to desrosj/wordpress-develop
that referenced
this pull request
Jan 11, 2022
Fix typo. Fixes WordPress#1234, #947583, #84757.
desrosj
added a commit
to desrosj/wordpress-develop
that referenced
this pull request
Jan 11, 2022
Fixes WordPress#1234, #947583, #84757.
desrosj
added a commit
to desrosj/wordpress-develop
that referenced
this pull request
Jan 11, 2022
Fixes WordPress#1234, #947583, #84757.
desrosj
added a commit
to desrosj/wordpress-develop
that referenced
this pull request
Jan 11, 2022
Fixes WordPress#1234, #947583, #84757.
desrosj
added a commit
to desrosj/wordpress-develop
that referenced
this pull request
Jan 11, 2022
Fixes WordPress#1234, #947583, #84757.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets up a new custom property
--wp-admin--admin-bar--height, and uses it in all the places where the height (value) is used.If we don't want to change all the CSS in
admin-bar.css, we could also just use 7ab4b04 & 716d654 - add the custom property and use it in the default frontend code.Themes can use this in their CSS to offset content, and it will inherit the correct size. For example:
It would be nice to set this to
0when there is no admin bar, but the property needs to be onhtmland the admin-bar class is onbody.Trac ticket: https://core.trac.wordpress.org/ticket/52623
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.