#54275 Need to remove some empty html element (span)#1766
Closed
sayedulsayem wants to merge 1 commit intoWordPress:masterfrom
Closed
#54275 Need to remove some empty html element (span)#1766sayedulsayem wants to merge 1 commit intoWordPress:masterfrom
sayedulsayem wants to merge 1 commit intoWordPress:masterfrom
Conversation
Contributor
|
Committed via https://core.trac.wordpress.org/changeset/51920. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In credits.php file, during show core contributors there are some empty span element which is not necessary to generate.
During showing core contribution it's accessing $person_data[3] without any checking. Not every contributor has a title so in some cases, $person_data[3] returns an empty string. In that case, It's not necessary to print empty strings into the span element.
See the screenshot below to understand it properly.
Trac ticket: https://core.trac.wordpress.org/ticket/54275