Twenty Twenty-Two: use custom values in spacers#2319
Draft
jffng wants to merge 1 commit intoWordPress:trunkfrom
Draft
Twenty Twenty-Two: use custom values in spacers#2319jffng wants to merge 1 commit intoWordPress:trunkfrom
jffng wants to merge 1 commit intoWordPress:trunkfrom
Conversation
jffng
commented
Feb 15, 2022
Author
jffng
left a comment
jffng
left a comment
There was a problem hiding this comment.
This is a draft for now because the required Gutenberg PR is not backported yet, as far as I can tell:
| <!-- /wp:image --></div> | ||
| <!-- /wp:group --><!-- wp:spacer {"height":66} --> | ||
| <div style="height:66px" aria-hidden="true" class="wp-block-spacer"></div> | ||
| <!-- /wp:group --><!-- wp:spacer {"height":"calc(var(--wp--custom--spacing--large, 8rem) - var( --wp--style--block-gap ))"} --> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use custom variable based values in spacer blocks instead of static pixel based ones.
Trac ticket: https://core.trac.wordpress.org/ticket/55169
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.