Add test coverage for wp_date.#2643
Closed
costdev wants to merge 7 commits intoWordPress:trunkfrom
Closed
Conversation
Contributor
peterwilsoncc
left a comment
peterwilsoncc
left a comment
There was a problem hiding this comment.
Added a note inline, remind me about this after RC1 as tests can be committed at any time.
costdev
force-pushed
the
wp_date_unit_tests
branch
from
a6f80f9 to
f19a71b
Compare
Contributor
peterwilsoncc
left a comment
peterwilsoncc
left a comment
There was a problem hiding this comment.
LGTM.
I've got a note inline about some unneeded saving of data/incorrect if it is required.
Is it possible for the test suite to run in an unexpected timezone and mess up the expectations here (for example an Aussie timezone woulld switch am to pm, etc). If possible, then it is probably worth setting the timezone for the tests.
Contributor
Contributor
Author
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/53485