Skip to content

fix: Wrong escaping in 'class-wp-nav-menu-widget.php' file#2936

Closed
hz-tyfoon wants to merge 3 commits intoWordPress:trunkfrom
hz-tyfoon:first-contribute
Closed

fix: Wrong escaping in 'class-wp-nav-menu-widget.php' file#2936
hz-tyfoon wants to merge 3 commits intoWordPress:trunkfrom
hz-tyfoon:first-contribute

Conversation

@hz-tyfoon
Copy link

Trac ticket: 56128


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link

github-actions bot commented Jul 1, 2022

Hi @hz-tyfoon! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in this blog post.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

Thank you,
The WordPress Project

@hz-tyfoon
Copy link
Author

Sorry. Just updated the PR.
Looks like it wasn't "wrong escaping". So, added inline comment to explain why 'esc_attr()' used there instead of 'esc_url()'.
Thanks @SergeyBiryukov

@SergeyBiryukov
Copy link
Member

Thanks for the PR! Merged in r53630.

@hz-tyfoon hz-tyfoon deleted the first-contribute branch July 7, 2022 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants