Trac 58114: Dashboard: Updates activity widget layout.#4319
Closed
kebbet wants to merge 4 commits intoWordPress:trunkfrom
Closed
Trac 58114: Dashboard: Updates activity widget layout.#4319kebbet wants to merge 4 commits intoWordPress:trunkfrom
kebbet wants to merge 4 commits intoWordPress:trunkfrom
Conversation
Contributor
|
Hey @kebbet it looks like there is something wrong in your fourth PR: we seems to have even/odd background on filters, too… 🤔 |
Author
|
Thanks for the heads up @audrasjb Looking at the CSS, and spinning up the dev environment again, I can not recreate my screenshot of the filters. Strange indeed, but the code in this PR looks ok to me. Screenshot of RTL-version, with current PR. |
Contributor
|
Ok thanks for the confirmation! I'll have a look then :) |
Contributor
|
Before patch: After patch: |
Contributor
|
Committed in https://core.trac.wordpress.org/changeset/55889 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://core.trac.wordpress.org/ticket/58114
LTR - before (below)
LTR - after (below)
RTL - before (below)
RTL - after (below)