Replace usage of substr with str_starts_with and str_ends_with

[Soean]

Trac ticket: https://core.trac.wordpress.org/ticket/58220

---

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

[spacedmonkey]

@Soean There seems to be a unit test failure for php 8.1

[Soean]

@spacedmonkey I merged trunk, now the tests look good.

[spacedmonkey]

Looks good to me!

[spacedmonkey]

@joelataccelm A backward compatibility shim was added 3cc8f12 ( in WP 5.9.0 ). These are already in core in many many places. WordPress currently supports down to PHP 5.6.

[joelataccelm]

@joelataccelm A backward compatibility shim was added 3cc8f12 ( in WP 5.9.0 ). These are already in core in many many places. WordPress currently supports down to PHP 5.6.

got it, sorry. I just spotted that in the latest compat file. the version I noticed this fatal erroring on doesn't have the str_ functions in the compat file, so I just need to upgrade.

[sabernhardt]

According to the Hello Dolly plugin page, it should be compatible with WordPress 4.6 or higher. The str_starts_with function would require either PHP8 or WP5.9.

[SergeyBiryukov]

Thanks for the PR! Merged in r55990.