[Obsolete] Trac 58974: Modernize wp-embed script to remove IE≤11 code and support for WP<4.4#4964
Closed
westonruter wants to merge 10 commits intotrunkfrom
Closed
[Obsolete] Trac 58974: Modernize wp-embed script to remove IE≤11 code and support for WP<4.4#4964westonruter wants to merge 10 commits intotrunkfrom
westonruter wants to merge 10 commits intotrunkfrom
Conversation
Member
Author
|
I erroneously pushed the branch to origin and not to my fork. Closing this PR in favor of #4967 |
Member
Author
This won't happen again, thanks to: git remote set-url --push origin https://github.com/westonruter/wordpress-develop.git |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
loadevent handler inwp-embedsince IE10+ supportDOMContentLoaded.document.createElement('a')in favor of the newerURLclass (supported in all browsers but obsolete IE11).substring()instead of deprecatedsubstr()method.wp-embed.jsnot include ampersands, considering this was put in place for WP<4.3 which now accounts for only 1.43% of sites. This includes the elimination of theverify:wp-embedgrunt task.Trac ticket: https://core.trac.wordpress.org/ticket/58974
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.