Skip to content

[Obsolete] Trac 58974: Modernize wp-embed script to remove IE≤11 code and support for WP<4.4#4964

Closed
westonruter wants to merge 10 commits intotrunkfrom
trac-58974
Closed

[Obsolete] Trac 58974: Modernize wp-embed script to remove IE≤11 code and support for WP<4.4#4964
westonruter wants to merge 10 commits intotrunkfrom
trac-58974

Conversation

@westonruter
Copy link
Member

  • Remove obsolete load event handler in wp-embed since IE10+ support DOMContentLoaded.
  • Replace obsolete use of document.createElement('a') in favor of the newer URL class (supported in all browsers but obsolete IE11).
  • Remove obsolete IE10/IE11 code.
  • Combine condtionals.
  • Use substring() instead of deprecated substr() method.
  • Eliminate the stipulation that wp-embed.js not include ampersands, considering this was put in place for WP<4.3 which now accounts for only 1.43% of sites. This includes the elimination of the verify:wp-embed grunt task.

Trac ticket: https://core.trac.wordpress.org/ticket/58974


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@westonruter westonruter changed the title Trac 58974: Modernize wp-embed script to remove IE≤11 code and support for WP<4.4 [Obsolete] Trac 58974: Modernize wp-embed script to remove IE≤11 code and support for WP<4.4 Aug 4, 2023
@westonruter
Copy link
Member Author

I erroneously pushed the branch to origin and not to my fork. Closing this PR in favor of #4967

@westonruter westonruter closed this Aug 4, 2023
@westonruter
Copy link
Member Author

I erroneously pushed the branch to origin and not to my fork.

This won't happen again, thanks to:

git remote set-url --push origin https://github.com/westonruter/wordpress-develop.git 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant