Plugins: Move misplaced return statement in wp_get_plugin_action_button().

[costdev]

Trac ticket: https://core.trac.wordpress.org/ticket/61400

[github-actions]

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

• The Plugin and Theme Directories cannot be accessed within Playground.
• All changes will be lost when closing a tab with a Playground instance.
• All changes will be lost when refreshing the page.
• A fresh instance is created each time the link below is clicked.
• Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
  it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props costdev, hellofromtonya.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[hellofromtonya]

This approach works well for the specific needs of this ticket and the issue it addresses. That said, the function under test will need additional plugin mashups (i.e. different $data) for its various test scenarios.

It might be good to start off with a helper function that builds / creates the plugin for each test.

Is there already examples / usage within the test suite? Yes.

Example, WP_REST_Plugins_Controller_Test::create_test_plugin().

What do you think @costdev?

[hellofromtonya]

The more I think about this -> let's tackle it when adding more tests. The current approach is within scope for this ticket.

[hellofromtonya]

LGTM 👍 Ready for commit

[hellofromtonya]

Committed via https://core.trac.wordpress.org/changeset/58396.