Skip to content

Fixed : Convert div to main tag for web accessibility #7274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
narenin wants to merge 4 commits into
base: trunk
Choose a base branch
from
Open

Fixed : Convert div to main tag for web accessibility #7274

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
405af21
Fixed : Convert div to main tag for web accessibility
narenin Aug 30, 2024
e13ae3a
Added the formatting as per the doc
narenin Sep 1, 2024
8c2be70
Update src/wp-includes/block-template.php
narenin Sep 2, 2024
d5219e4
Update src/wp-includes/block-template.php
narenin Sep 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/wp-includes/block-template.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,9 +268,21 @@ function get_the_block_template_html() {
$content = wp_filter_content_tags( $content, 'template' );
$content = str_replace( ']]>', ']]>', $content );

/**
* Filters the wrapper element used in the site blocks.
*
* This filter allows the modification of the wrapper element that encloses the site blocks.
*
* @since 6.7.0
*
* @param string $element The HTML element to be used as the wrapper. Default 'div'.
* @param string $content The content to be wrapped.
*/
$wrapper_element = apply_filters( 'wp_site_blocks_wrapper_element', 'div', $content );
Copy link
Copy Markdown
Member

@mukeshpanchal27 mukeshpanchal27 Aug 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add filter doc. per https://developer.wordpress.org/coding-standards/inline-documentation-standards/php/#4-hooks-actions-and-filters.

Copy link
Copy Markdown
Author

@narenin narenin Sep 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mukeshpanchal27 Thanks for reviewing this, I have implemented the suggestions please check.


// Wrap block template in .wp-site-blocks to allow for specific descendant styles
// (e.g. `.wp-site-blocks > *`).
return '<div class="wp-site-blocks">' . $content . '</div>';
return "<{$wrapper_element} class=\"wp-site-blocks\">{$content}</{$wrapper_element}>";
}

/**
Expand Down